Skip to content

fix: separate optional context discovery from required evidence - #44

Merged
AppSolves merged 2 commits into
mainfrom
fix/final-review-completeness
Nov 15, 2026
Merged

AppSolves merged 2 commits into
mainfrom
fix/final-review-completeness

Conversation

@AppSolves

@AppSolves AppSolves commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

A speculative filename lookup must not turn an otherwise complete review into an incomplete one. Separate optional discovery from mandatory content retrieval: the new /probe operation returns only existence from verified immutable Git tree metadata; /file continues to require verified contents and permanently invalidates completeness if it fails. Both share the existing 24-request and GitHub API budgets. There is no model-controlled required: false escape hatch, additional inference pass or policy relaxation.

Verified absence is distinct from API failures, special Git objects, size limits and integrity failures. Probes never materialize source or satisfy content evidence; API/tree verification failures remain fail-closed. Neither probes nor later successful reads can clear missing changed-file, trusted-instruction or dependency evidence.

Preserve the original final-completion correction: close/drain lookups before evaluating the trusted host gate, retain validated findings in non-approving submissions, and report only safe completion fields and approved failure codes. Source, prompts, paths, credentials and model output are not diagnostic fields.

Regression coverage includes optional absence, mandatory absence, initially missing dependencies, API 404/403/429/500, truncated/inconsistent trees, special objects, oversized/corrupt blobs, shared lookup limits and concurrent lookups. The actual runner test exercises both paths through a real context socket and preserves findings on mandatory failure. Docker acceptance uses the actual pinned Codex binary with scripted Responses and verifies the probe/file socket contract and existing isolation.

Validation:

  • npm run check: typecheck, lint, all 224 tests and build passed.
  • npm run test:clean: fresh dependency installation and full check passed without generated Env declarations.
  • npm run test:workers, npm run test:web, npm run catalog:check: passed.
  • Docker build and npm run test:sandbox: passed with synthetic providers.
  • npm audit --audit-level=moderate: zero vulnerabilities; Actionlint and Wrangler deployment dry-run passed.

No merge, deployment, downstream repository changes, trusted-pin changes, live inference or authorization/credential changes are part of this task. Metadata probes cannot prove exhaustive model reasoning; failed required evidence still prohibits approval and merging.

@AppSolves AppSolves changed the title fix: diagnose final completeness after on-demand context fix: separate optional context discovery from required evidence Nov 15, 2026
@AppSolves
AppSolves merged commit 14804ea into main Nov 15, 2026
4 checks passed
@AppSolves
AppSolves deleted the fix/final-review-completeness branch November 15, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant